Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21] server: filter sysctls passed through CRI if host namespace #5686

Merged
merged 2 commits into from Mar 1, 2022
Merged

[1.21] server: filter sysctls passed through CRI if host namespace #5686

merged 2 commits into from Mar 1, 2022

Conversation

haircommander
Copy link
Member

This is an automated cherry-pick of #5610

Fix a bug where a pod given a host IPC or network namespace could configure sysctls on the host

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 25, 2022
@haircommander
Copy link
Member Author

/kind bug

@openshift-ci openshift-ci bot requested review from rhatdan and sameo February 25, 2022 15:38
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2022
@haircommander
server: skip sysctls that would affect the host
dd19459 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
test: add test for skipped sysctls
1cb18d8 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #5686 (1cb18d8) into release-1.21 (13048cc) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.21    #5686      +/-   ##
================================================
- Coverage         45.01%   44.98%   -0.03%     
================================================
  Files               109      109              
  Lines             11050    11056       +6     
================================================
  Hits               4974     4974              
- Misses             5597     5603       +6     
  Partials            479      479

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2022 •
edited

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 1cb18d8 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 1cb18d8 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saschagrunert
saschagrunert approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member Author

/retest-required

@haircommander
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@haircommander haircommander added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 030755e into cri-o:release-1.21 Mar 1, 2022
@haircommander
Copy link
Member Author

/cherry-pick release-1.20

@haircommander
Copy link
Member Author

/cherry-pick release-1.19

@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #5702

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 4, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #5703

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

@sameo sameo Awaiting requested review from sameo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haircommander @openshift-cherrypick-robot @saschagrunert @openshift-merge-robot