Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.19] server: filter sysctls passed through CRI if host namespace #5703

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5686

/assign haircommander

Fix a bug where a pod given a host IPC or network namespace could configure sysctls on the host

Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #5703 (c462bd6) into release-1.19 (191f731) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.19    #5703      +/-   ##
================================================
- Coverage         43.31%   43.28%   -0.03%     
================================================
  Files               115      115              
  Lines              9888     9894       +6     
================================================
  Hits               4283     4283              
- Misses             5222     5228       +6     
  Partials            383      383              

@haircommander haircommander changed the title [release-1.19] [1.21] server: filter sysctls passed through CRI if host namespace [release-1.19] server: filter sysctls passed through CRI if host namespace Mar 4, 2022
@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

/lgtm
/approve
/override ci/openshift-jenkins/integration_rhel

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_rhel

In response to this:

/lgtm
/approve
/override ci/openshift-jenkins/integration_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@haircommander
Copy link
Member

/override ci/openshift-jenkins/integration_fedora

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_fedora

In response to this:

/override ci/openshift-jenkins/integration_fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 c462bd6 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2034546 into cri-o:release-1.19 Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants