New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.22] oci: fix segfault in pod stop code #5803
[1.22] oci: fix segfault in pod stop code #5803
Conversation
by only closing the stopStoppingChan once Signed-off-by: Peter Hunt <pehunt@redhat.com>
Codecov Report
@@ Coverage Diff @@
## release-1.22 #5803 +/- ##
=============================================
Coverage 43.78% 43.78%
=============================================
Files 120 120
Lines 11844 11846 +2
=============================================
+ Hits 5186 5187 +1
- Misses 6167 6168 +1
Partials 491 491 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-1.21 |
@haircommander: new pull request created: #5828 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
by only closing the stopStoppingChan once
Signed-off-by: Peter Hunt pehunt@redhat.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
cherry-pick of #5782
/kind bug