Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.21] oci: fix segfault in pod stop code #5828

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5803

/assign haircommander

fix a segfault when multiple container stops come in for the same container

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 27, 2022
@openshift-ci openshift-ci bot requested review from fidencio and nalind April 27, 2022 14:44
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #5828 (a1765d5) into release-1.21 (52bce89) will increase coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head a1765d5 differs from pull request most recent head ad17750. Consider uploading reports for the commit ad17750 to get more accurate results

@@              Coverage Diff              @@
##           release-1.21    #5828   +/-   ##
=============================================
  Coverage         44.98%   44.99%           
=============================================
  Files               109      109           
  Lines             11056    11058    +2     
=============================================
+ Hits               4973     4975    +2     
  Misses             5604     5604           
  Partials            479      479           

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@haircommander haircommander changed the title [release-1.21] [1.22] oci: fix segfault in pod stop code [release-1.21] oci: fix segfault in pod stop code May 10, 2022
@haircommander
Copy link
Member

needs #5858

by only closing the stopStoppingChan once

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander force-pushed the cherry-pick-5803-to-release-1.21 branch from 23783ea to ad17750 Compare May 11, 2022 14:13
@haircommander
Copy link
Member

/retest
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 23783ea link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 ad17750 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 173d83e into cri-o:release-1.21 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants