Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unknown control character errors more gracefully #3

Closed
coccyx opened this issue Jan 21, 2021 · 0 comments · Fixed by #24
Closed

Handle unknown control character errors more gracefully #3

coccyx opened this issue Jan 21, 2021 · 0 comments · Fixed by #24
Assignees
Labels
Projects
Milestone

Comments

@coccyx
Copy link
Collaborator

coccyx commented Jan 21, 2021

Currently panics and exits. Should retry with ascii skipped.

@coccyx coccyx added the cli label Jan 21, 2021
@coccyx coccyx self-assigned this Jan 21, 2021
@coccyx coccyx added this to To do in 0.5 Release Jan 23, 2021
@coccyx coccyx moved this from To do to In progress in 0.5 Release Jan 25, 2021
coccyx added a commit that referenced this issue Jan 25, 2021
* #3: Should handle unknown characters in dashboard event output more
gracefully.
* #8: Now returns event count after filtering, except for with JS
expressions.
* #9: Q now exits dash.
* #12: Help should now have consistent capitalization.
* #7: Scope run now has more examples.
* #4: Commands which fail validation now print help.
* #1: Failed executions now prompt to clean empty session.
* #19: Log Regex is now smarter about picking up log directories or
files.
* #17: scope metrics -c no longer fails silently.
@coccyx coccyx added this to the 0.5 milestone Jan 25, 2021
@coccyx coccyx moved this from In progress to Done in 0.5 Release Feb 1, 2021
michalbiesek added a commit that referenced this issue Jul 14, 2023
- In the case of the `host` application [1], the `host` app uses
 `libuv` to perform the DNS lookup.

- `uv__udp_sendmsg` uses the `syscall` to perform the sending message operation.
  The decision of whether to use `syscall` or `sendmsg` is based on checking the value of the
  `uv__sendmmsg_avail` variable in `uv__udp_sendmsg` [2].

- `uv__udp_recvmsg` uses `recvmsg` to perform the receiving message operation.
  The decision of whether to use `syscall` or `recvmsg` is based on checking the result
  of `uv_udp_using_recvmmsg` [3].

- The above explains why `libuv` uses `syscall` for sending messages and `recvmsg` for receiving messages.

- Additionally `libuv` check support for `recvmmsg()` and `sendmmsg()` using
  `uv__udp_mmsg_init` with calling `uv__sendmmsg(s, NULL, 0, 0)` [4]

The stack traces for the and `uv__udp_sendmsg` and `uv__udp_recvmsg`:

```
[#0] syscall()
[#1] uv__sendmmsg(...)
[#2] uv__udp_sendmmsg(..)
[#3] uv__udp_sendmsg(...)
[#4] uv__udp_send(...)
[#5] uv_udp_send(...)
```

```
[#0] recvmsg
[#1] uv__udp_recvmsg
```

Ref:
[1] https://github.com/isc-projects/bind9
[2] libuv/libuv@3d71366
[3] libuv/libuv@6b5aa66
[4] libuv/libuv@3d71366

Closes: #1586
michalbiesek added a commit that referenced this issue Jul 14, 2023
- In the case of the `host` application [1], the `host` app uses
 `libuv` to perform the DNS lookup.

- `uv__udp_sendmsg` uses the `syscall` to perform the sending message operation.
  The decision of whether to use `syscall` or `sendmsg` is based on checking the value of the
  `uv__sendmmsg_avail` variable in `uv__udp_sendmsg` [2].

- `uv__udp_recvmsg` uses `recvmsg` to perform the receiving message operation.
  The decision of whether to use `syscall` or `recvmsg` is based on checking the result
  of `uv_udp_using_recvmmsg` [3].

- The above explains why `libuv` uses `syscall` for sending messages and `recvmsg` for receiving messages.

- Additionally `libuv` check support for `recvmmsg()` and `sendmmsg()` using
  `uv__udp_mmsg_init` with calling `uv__sendmmsg(s, NULL, 0, 0)` [4]

The stack traces for the and `uv__udp_sendmsg` and `uv__udp_recvmsg`:

```
[#0] syscall()
[#1] uv__sendmmsg(...)
[#2] uv__udp_sendmmsg(..)
[#3] uv__udp_sendmsg(...)
[#4] uv__udp_send(...)
[#5] uv_udp_send(...)
```

```
[#0] recvmsg
[#1] uv__udp_recvmsg
```

Ref:
[1] https://github.com/isc-projects/bind9
[2] libuv/libuv@3d71366
[3] libuv/libuv@6b5aa66
[4] libuv/libuv@3d71366

Closes: #1586
michalbiesek added a commit that referenced this issue Jul 15, 2023
- In the case of the `host` application [1], the `host` app uses
 `libuv` to perform the DNS lookup.

- `uv__udp_sendmsg` uses the `syscall` to perform the sending message operation.
  The decision of whether to use `syscall` or `sendmsg` is based on checking the value of the
  `uv__sendmmsg_avail` variable in `uv__udp_sendmsg` [2].

- `uv__udp_recvmsg` uses `recvmsg` to perform the receiving message operation.
  The decision of whether to use `syscall` or `recvmsg` is based on checking the result
  of `uv_udp_using_recvmmsg` [3].

- The above explains why `libuv` uses `syscall` for sending messages and `recvmsg` for receiving messages.

- Additionally `libuv` check support for `recvmmsg()` and `sendmmsg()` using
  `uv__udp_mmsg_init` with calling `uv__sendmmsg(s, NULL, 0, 0)` [4]

The stack traces for the and `uv__udp_sendmsg` and `uv__udp_recvmsg`:

```
[#0] syscall()
[#1] uv__sendmmsg(...)
[#2] uv__udp_sendmmsg(..)
[#3] uv__udp_sendmsg(...)
[#4] uv__udp_send(...)
[#5] uv_udp_send(...)
```

```
[#0] recvmsg
[#1] uv__udp_recvmsg
```

Ref:
[1] https://github.com/isc-projects/bind9
[2] libuv/libuv@3d71366
[3] libuv/libuv@6b5aa66
[4] libuv/libuv@3d71366

Closes: #1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant