Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes numerous issues. #24

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Fixes numerous issues. #24

merged 6 commits into from
Jan 26, 2021

Conversation

coccyx
Copy link
Collaborator

@coccyx coccyx commented Jan 25, 2021

* #3: Should handle unknown characters in dashboard event output more
gracefully.
* #8: Now returns event count after filtering, except for with JS
expressions.
* #9: Q now exits dash.
* #12: Help should now have consistent capitalization.
* #7: Scope run now has more examples.
* #4: Commands which fail validation now print help.
* #1: Failed executions now prompt to clean empty session.
* #19: Log Regex is now smarter about picking up log directories or
files.
* #17: scope metrics -c no longer fails silently.
@coccyx coccyx requested a review from iapaddler January 25, 2021 05:34
@coccyx coccyx added the cli label Jan 25, 2021
@coccyx
Copy link
Collaborator Author

coccyx commented Jan 25, 2021

This has reverted @jrcheli commit and we'll need to resolve how to handle this to make tests succeed. Will chat Monday.

@coccyx
Copy link
Collaborator Author

coccyx commented Jan 26, 2021

@iapaddler can you review? We should be ready to merge. I'm working on getting tests running better/more successfully in another branch.

@iapaddler iapaddler closed this Jan 26, 2021
@iapaddler iapaddler reopened this Jan 26, 2021
@iapaddler iapaddler merged commit ed5d7ca into master Jan 26, 2021
@coccyx coccyx moved this from In progress to Done in 0.5 Release Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment