Funchook install fail 1293

[michalbiesek]

QA instructions:

Because of an AppScope bug, when you attached to a running Redis server process, the Redis server was restarting.

Here's how to verify that the bug is fixed.


# Install Redis
sudo apt install redis -y

# Running the above command should both install Redis and start Redis as a service. 
# To verify, run this command:

sudo systemctl status redis

# Verify that MemoryDenyWriteExecute is set to true - this was required to reproduce the bug.

grep MemoryDenyWriteExecute /lib/systemd/system/redis-server.service

# Set your terminal to display the Redis service PID once per second.
# That way we'll know if Redis restarts.
watch -n 1 pgrep redis

# In a new terminal, attach to the Redis server PID:
sudo scope attach redis

# At this point, the AppScope library should be loaded and the Redis server process should be scoped.
# To verify that this did not cause Redis to restart, connect to the Redis server via the Redis CLI.
redis-cli
set foo bar

# If the bug is NOT fixed, you should see that the PID in the first terminal has changed, and you should see a segfault like the following:
sudo journalctl -u redis-server.service
<user_name> systemd[1]: redis-server.service: Main process exited, code=dumped, status=11/SEGV
<user_name> systemd[1]: redis-server.service: Failed with result 'core-dump'.