Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funchook install fail 1293 #1298

Merged
merged 7 commits into from
Feb 7, 2023
Merged

Funchook install fail 1293 #1298

merged 7 commits into from
Feb 7, 2023

Commits on Feb 3, 2023

  1. Updatefunchook_install log message

    @michalbiesek
    michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b1c238a View commit details
    Browse the repository at this point in the history

  2. Destroy funchook when funchook_install fails

    @michalbiesek
    michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    ff26e80 View commit details
    Browse the repository at this point in the history

  3. Add funchook_destroy in wrap_go.c

    @michalbiesek
    michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b75fbaa View commit details
    Browse the repository at this point in the history

  4. (#1293) Verify funchook_install permission 

    - the funhook install can fail in scenario where
  systemd `MemoryDenyWriteExecute` setting is on
```
  ...Attempts to create memory mappings that are writable and executable
  at the same time, or
  to change existing memory mappings to become executable, or
  mapping shared memory segments as executable, are prohibited...
```
  Ref: https://www.freedesktop.org/software/systemd/man/systemd.exec.html

  Closes: #1293
    @michalbiesek
    michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4a5480e View commit details
    Browse the repository at this point in the history

  5. Extend unit test with ostest 

    - validate `osMemPermAllowWrite` and `osMemPermRestore`
    @michalbiesek
    michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5660b1f View commit details
    Browse the repository at this point in the history

  6. Fix typo initally ==> initially

    @michalbiesek
    michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e8378d8 View commit details
    Browse the repository at this point in the history

  7. Modify msg in case osMemPermAllow fails

    @michalbiesek
    Abe Raher authored and michalbiesek committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    de19873 View commit details
    Browse the repository at this point in the history