Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional tests for process deployment #11

Closed
24 tasks done
Tracked by #141
fmigneault opened this issue Mar 9, 2019 · 4 comments · Fixed by #470
Closed
24 tasks done
Tracked by #141

functional tests for process deployment #11

fmigneault opened this issue Mar 9, 2019 · 4 comments · Fixed by #470
Assignees
Labels
ci/tests Tests of the package and features help wanted Extra attention is needed

Comments

@fmigneault
Copy link
Collaborator

fmigneault commented Mar 9, 2019

relates to #3

  • add test to deploy process with CWL DockerRequirement
    • reference .cwl in href instead of ProcessDescription (see DockerRequirement note)
    • reference .cwl in owsContext within ProcessDescription -> Process
    • reference .cwl in executionUnit (combined with deploymentProfileName) (see DockerRequirement note)
  • add test to deploy process with CWL WPS1Requirement (added in refactor wps-process for workflow steps #372)
    (must provide process in requirement)
    • reference .cwl in href instead of ProcessDescription
    • reference .cwl in owsContext within ProcessDescription -> Process
    • reference .cwl in executionUnit (combined with deploymentProfileName)
  • add test to deploy process with WPS1 DescribeProcess endpoint
    • reference WPS1 in href instead of ProcessDescription
    • reference WPS1 in owsContext within ProcessDescription -> Process
    • reference WPS1 in executionUnit (combined with deploymentProfileName)
  • add test to deploy process with WPS1 service GetCapabilities endpoint
    (must include identifier=... to derive DescribeProcess)
    • reference WPS1 in href instead of ProcessDescription
    • reference WPS1 in owsContext within ProcessDescription -> Process
    • reference WPS1 in executionUnit (combined with deploymentProfileName)
  • add test to deploy process with WPS3 (REST) GET Process endpoint
    • reference WPS3 in href instead of ProcessDescription
    • reference WPS3 in owsContext within ProcessDescription -> Process
    • reference WPS3 in executionUnit (combined with deploymentProfileName)
  • Deploy process directly with CWL content #434
    • package directly provided as JSON
    • reference to remote CWL package
  • test with Workflow using deployed sub-processes

DockerRequirement note

Implementation missing from below tests but feature is tested across many other tests since it is the most common use case.
Should implement just to make sure it is always evaluated for consistency.

# FIXME: implement
@pytest.mark.skip(reason="not implemented")
def test_deploy_process_CWL_DockerRequirement_href(self):
raise NotImplementedError
# FIXME: implement
@pytest.mark.skip(reason="not implemented")
def test_deploy_process_CWL_DockerRequirement_owsContext(self):
raise NotImplementedError
# FIXME: implement
@pytest.mark.skip(reason="not implemented")
def test_deploy_process_CWL_DockerRequirement_executionUnit(self):
raise NotImplementedError

@fmigneault fmigneault added help wanted Extra attention is needed ci/tests Tests of the package and features labels Mar 9, 2019
@dbyrns
Copy link
Contributor

dbyrns commented Mar 13, 2019

@davidcaron once your CWT implementation ready, you should be able to contribute to this functional tests issue and add, as discussed, a subsetter using the ESGF backend.

@fmigneault
Copy link
Collaborator Author

@dbyrns
using the above referenced fix + commit 077d9a8 + following wps_providers.yml config, WPS-2 processes are deployed successfully with their CWL WPS1Requirement on startup.

providers:
  - url: https://colibri.crim.ca/twitcher/ows/proxy/flyingpigeon/wps?service=WPS&request=describeprocess&version=1.0.0&identifier=subset_bbox
    name: colibri-flyingpieon
  - url: https://finch.crim.ca/wps?service=WPS&request=describeprocess&version=1.0.0&identifier=ice_days
    name: finch

@dbyrns
Copy link
Contributor

dbyrns commented Mar 14, 2019

Just be careful with the naming scheme... what we deploy in Weaver are processes not providers.
I would prefer to see a wps_processes.yml config file looking like this to avoid confusion :

processes:
  - url: https://colibri.crim.ca/twitcher/ows/proxy/flyingpigeon/wps?service=WPS&request=describeprocess&version=1.0.0&identifier=subset_bbox
    name: colibri-flyingpieon-subset_bbox
  - url: https://finch.crim.ca/wps?service=WPS&request=describeprocess&version=1.0.0&identifier=ice_days
    name: finch-ice_days

@davidcaron davidcaron mentioned this issue Mar 19, 2019
5 tasks
fmigneault added a commit that referenced this issue Mar 26, 2019
This was referenced Jun 11, 2019
@fmigneault fmigneault pinned this issue Dec 3, 2019
@fmigneault fmigneault unpinned this issue May 13, 2020
fmigneault added a commit that referenced this issue Jun 9, 2022
fmigneault added a commit that referenced this issue Aug 19, 2022
fmigneault added a commit that referenced this issue Aug 23, 2022
…rkflow tests (relates to #11) + OGC Media-Types format for CWL
fmigneault added a commit that referenced this issue Sep 12, 2022
…rkflow tests (relates to #11) + OGC Media-Types format for CWL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/tests Tests of the package and features help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants