Relax command name format

cristalhq · Jun 27, 2022 · 889426d · 889426d
1 parent 2a8237c
commit 889426d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/acmd.go b/acmd.go
@@ -241,7 +241,7 @@ func isStringValid(s string) bool {
 	}
 	for _, c := range s {
 		if !(('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z') ||
-			('0' <= c && c <= '9') || c == '-' || c == '_') {
+			('0' <= c && c <= '9') || c == '-' || c == '_' || c == ':') {
 			return false
 		}
 	}

diff --git a/acmd_test.go b/acmd_test.go
@@ -204,6 +204,10 @@ func TestRunnerInit(t *testing.T) {
 		cfg        Config
 		wantErrStr string
 	}{
+		{
+			cmds:       []Command{{Name: "app:create", Do: nopFunc}},
+			wantErrStr: ``,
+		},
 		{
 			cmds:       []Command{{Name: "", Do: nopFunc}},
 			wantErrStr: `command "" must contains only letters, digits, - and _`,
@@ -276,7 +280,7 @@ func TestRunnerInit(t *testing.T) {
 	for _, tc := range testCases {
 		err := RunnerOf(tc.cmds, tc.cfg).Run()
 
-		if got := err.Error(); !strings.Contains(got, tc.wantErrStr) {
+		if got := err.Error(); tc.wantErrStr != "" && !strings.Contains(got, tc.wantErrStr) {
 			t.Fatalf("want %q got %q", tc.wantErrStr, got)
 		}
 	}