Skip to content

Commit

Permalink
Do not leak values in errors (#137)
Browse files Browse the repository at this point in the history
  • Loading branch information
cristaloleg committed Oct 30, 2022
1 parent 7672f5b commit 68ef706
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions aconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,8 @@ func (l *Loader) loadFile(file string) error {
}

if !l.config.AllowUnknownFields {
for env, value := range actualFields {
return fmt.Errorf("unknown field in file %q: %s=%v (see AllowUnknownFields config param)", file, env, value)
for env := range actualFields {
return fmt.Errorf("unknown field in file %q: %s (see AllowUnknownFields config param)", file, env)
}
}
return nil
Expand Down Expand Up @@ -394,9 +394,9 @@ func (l *Loader) postEnvCheck(values map[string]interface{}, dupls map[string]st
for name := range dupls {
delete(values, name)
}
for env, value := range values {
for env := range values {
if strings.HasPrefix(env, l.config.EnvPrefix) {
return fmt.Errorf("unknown environment var %s=%v (see AllowUnknownEnvs config param)", env, value)
return fmt.Errorf("unknown environment var %s (see AllowUnknownEnvs config param)", env)
}
}
return nil
Expand Down Expand Up @@ -425,9 +425,9 @@ func (l *Loader) postFlagCheck(values map[string]interface{}, dupls map[string]s
for name := range dupls {
delete(values, name)
}
for flag, value := range values {
for flag := range values {
if strings.HasPrefix(flag, l.config.FlagPrefix) {
return fmt.Errorf("unknown flag %s=%v (see AllowUnknownFlags config param)", flag, value)
return fmt.Errorf("unknown flag %s (see AllowUnknownFlags config param)", flag)
}
}
return nil
Expand Down

0 comments on commit 68ef706

Please sign in to comment.