Fix deep file parsing not working when flag delimiter is set #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
approved these changes
Oct 18, 2021
|
Looks good, merging, thank you for the fix. I hope to update internals soon, but better to fix now.
Can you explain why? just curious is this on |
Probably not, some weird bug where t.TempDir() tries to create a dir in my WINDOWS folder when I run all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File parsing with nested structure doesn't work currently when a different flag delimiter than default "." is set. So I tried to fix that here.
Couldn't run the full test suite on my machine, so I am not 100% sure that this change doesn't break anything else.