Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar perf #25

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Moar perf #25

merged 3 commits into from
Apr 13, 2023

Conversation

cristaloleg
Copy link
Member

@cristaloleg cristaloleg commented Apr 13, 2023

benchstat:

goos: darwin
goarch: arm64
pkg: github.com/cristalhq/builq
                 │   old2.txt   │              new2.txt               │
                 │    sec/op    │    sec/op     vs base               │
BuildSimple-10      298.5n ± 3%    273.6n ± 1%  -8.36% (p=0.000 n=10)
BuildManyArgs-10    665.6n ± 1%    651.6n ± 1%  -2.10% (p=0.002 n=10)
BuildCached-10     0.6232n ± 0%   0.6232n ± 0%       ~ (p=0.469 n=10)
geomean             49.84n         48.07n       -3.56%

                 │    old2.txt    │                new2.txt                │
                 │      B/op      │     B/op      vs base                  │
BuildSimple-10       864.0 ± 0%       752.0 ± 0%  -12.96% (p=0.000 n=10)
BuildManyArgs-10   1.188Ki ± 0%     1.078Ki ± 0%   -9.21% (p=0.000 n=10)
BuildCached-10       0.000 ± 0%       0.000 ± 0%        ~ (p=1.000 n=10) ¹
geomean                         ²                  -7.55%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                 │   old2.txt   │              new2.txt               │
                 │  allocs/op   │ allocs/op   vs base                 │
BuildSimple-10     7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=10) ¹
BuildManyArgs-10   14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=10) ¹
BuildCached-10     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                       ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.76 🎉

Comparison is base (195ba9b) 95.23% compared to head (9c7c35c) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #25      +/-   ##
===========================================
+ Coverage   95.23%   100.00%   +4.76%     
===========================================
  Files           2         2              
  Lines         147       165      +18     
===========================================
+ Hits          140       165      +25     
+ Misses          6         0       -6     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
builq.go 100.00% <100.00%> (ø)
write.go 100.00% <100.00%> (+7.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cristaloleg cristaloleg merged commit 764bdc5 into main Apr 13, 2023
@cristaloleg cristaloleg deleted the perf2 branch April 13, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants