Skip to content

Commit

Permalink
Fix flaky TestHedgedResponseWins
Browse files Browse the repository at this point in the history
  • Loading branch information
cristaloleg committed Aug 19, 2023
1 parent 6504b04 commit 083abda
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 3 deletions.
33 changes: 33 additions & 0 deletions .github/workflows/adhoc_test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: adhoc-test

permissions: read-all

on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
run:
name: Build
runs-on: ubuntu-latest
timeout-minutes: 5
strategy:
fail-fast: true
matrix:
go: ['stable', 'oldstable']

steps:
- name: Check out code
uses: actions/checkout@v3

- name: Install Go
uses: actions/setup-go@v4
with:
go-version: ${{ matrix.go }}
check-latest: true

- name: Go Test
if: ${{ !inputs.skipTests }}
run: go test -v -count=100 -race -shuffle=on -coverprofile=coverage.txt ./...
6 changes: 3 additions & 3 deletions hedged_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ func TestHedgedResponseWins(t *testing.T) {
if err != nil {
t.Fatal(err)
}
client, metrics, err := hedgedhttp.NewClientAndStats(10*time.Millisecond, 5, nil)
client, metrics, err := hedgedhttp.NewClientAndStats(5*time.Millisecond, 5, nil)
if err != nil {
t.Fatalf("want nil, got %s", err)
}
Expand All @@ -363,10 +363,10 @@ func TestHedgedResponseWins(t *testing.T) {
t.Fatalf("Unnexpected actualRoundTrips: %v", actualRoundTrips)
}
if originalRequestWins := metrics.OriginalRequestWins(); originalRequestWins != 0 {
t.Fatalf("Unnexpected actualRoundTrips: %v", originalRequestWins)
t.Fatalf("Unnexpected originalRequestWins: %v", originalRequestWins)
}
if hedgedRequestWins := metrics.HedgedRequestWins(); hedgedRequestWins != 1 {
t.Fatalf("Unnexpected actualRoundTrips: %v", hedgedRequestWins)
t.Fatalf("Unnexpected hedgedRequestWins: %v", hedgedRequestWins)
}
if failedRoundTrips := metrics.FailedRoundTrips(); failedRoundTrips != 0 {
t.Fatalf("Unnexpected failedRoundTrips: %v", failedRoundTrips)
Expand Down

0 comments on commit 083abda

Please sign in to comment.