Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor issue, can not get correct sorted column when throw sored e… #40

Open
wants to merge 2 commits into
base: JBPM-8478
Choose a base branch
from

Conversation

bxf12315
Copy link

…vent

@bxf12315
Copy link
Author

@cristianonicolai I test it, I find a issue when throw sorted column event and ColumnSortedList's size more than 2, sorted column always is null.

@cristianonicolai
Copy link
Owner

@bxf12315 I added the check because we only sort by one column at time, what is the case for having a size of 2?

@bxf12315
Copy link
Author

@cristianonicolai when you click CreateOn (Or other column) more than twice, ColumnSortList's size will more than 2.

@bxf12315
Copy link
Author

bxf12315 commented May 14, 2019

@cristianonicolai I add "newListGrid.getColumnSortList().setLimit(1);" in method loadListTable. It is work. but I can't find the necessity of the code. I think just remove "check size less 1 " is enough.
I also remove code https://github.com/cristianonicolai/jbpm-wb/pull/40/files#diff-a5485d38408578707c1e8179af4297ffL562

@cristianonicolai cristianonicolai force-pushed the JBPM-8478 branch 2 times, most recently from 47a8b63 to eb293ce Compare May 14, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants