Improve etcd managed by docker UX #21
Conversation
|
Hey @bogdando , thank you for the PR and sorry that it took so long to check it. I didn't checked the yaml file, but I presume it's ok. The only issue I have is with force_new_cluster. I don't see any benefits for this to exist in puppet and I can see it only as very dangerous. When it's needed, it's probably safer to do it manually. |
|
@cristifalcas Thanks! The YAML config worked for me as I tested etcd in a container depoloyed by TripleO (OpenStack installer). |
|
I would prefer the parameter to be removed. I don't see any scenario where multiple runs with the parameter set to true is desired. So, I see it as "one time use" only. And I find it dangerous to provide it for automation. |
* Synch config opts from official docs * Add member's enable_v2, quota_backend_bytes and cluster's force_new_cluster config params. * Never force_new_cluster, it is a one-shot op, it might be destructive for periodic configuration management enforcement runs. Set it to False to protect from defaults' future changes as well. * Add a YAML conf file and ensure it under the /etc/etcd/etcd.yml, owned by the etcd u/g. This may to be used on a user's will, e.g.: "docker run .. /usr/bin/etcd --config-file..." Closes #20 Related #17 Signed-off-by: Bogdan Dobrelya <bogdando@mail.ru>
|
@cristifalcas Hi, done! |
|
Thank you @bogdando |
cluster's force_new_cluster config params
/etc/etcd/etcd.yml, owned by the etcd u/g.
This may to be used on a user's will, e.g.:
"docker run .. /usr/bin/etcd --config-file..."
Closes #20
Related #17
Signed-off-by: Bogdan Dobrelya bogdando@mail.ru