-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup README.md: Fixing some typos/bugs and etc. #17
Conversation
…erall helping make it more informative.
Sorry, tinkering with draft/WIP feature. |
@@ -25,21 +23,27 @@ npm install svelte-tag | |||
``` | |||
|
|||
```javascript | |||
import Component from "svelte-tag" | |||
import SvelteTag from "svelte-tag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an opinionated change. In my defense, not only did I naturally want to name it SvelteTag
, but apparently so have others (see dependents). Seems natural 😊, e.g. https://github.com/souriya777/elegant-seo-website/blob/main/_dev/src/js/svelte-elements.js
import App from "your-app.svelte" | ||
new Component({component:App,tagname:"hello-world",href="/your/stylesheet.css",attributes:["name"]}) | ||
|
||
new SvelteTag({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. @crisward It didn’t notice this until a fair bit later after this PR, but it turns out the use of new
here is not necessary at all.
Cleanup README.md:
Preview the way it looks here: https://github.com/patricknelson/svelte-tag/tree/adjust-readme