Add DYNAMIC_ROUTER setting #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I haz review ? |
|
looking |
erebe
reviewed
Feb 6, 2017
lib/carbon/client.py
Outdated
| """ | ||
|
|
||
| def __init__(self): | ||
| self.queue = deque() |
There was a problem hiding this comment.
Can you make it bounded, even if it is a big number.
lib/carbon/client.py
Outdated
| log.clients("Destination is down: %s:%d:%s (%d/%d)" % ( | ||
| destination[0], destination[1], destination[2], self.retries, | ||
| settings.DYNAMIC_ROUTER_MAX_RETRIES)) | ||
| if self.retries < settings.DYNAMIC_ROUTER_MAX_RETRIES: |
There was a problem hiding this comment.
ReconnectingClientFactory does that
The idea is that you want your consistent hashing ring to adapt itself when destinations are down. This change will remove destinations from the router when down and add them back when up. An additional buffer is created to store points when no destination is up, the receiving socket is also paused in this case to apply some back-pressure. When a node is removed from the router its points are re-injected to carbon to go through the new route.
iksaif
force-pushed
the
dynamic_router
branch
from
bfbf675
to
80e5f46
Compare
iksaif
commented
Feb 7, 2017
lib/carbon/client.py
Outdated
| log.clients("Destination is down: %s:%d:%s (%d/%d)" % ( | ||
| destination[0], destination[1], destination[2], self.retries, | ||
| settings.DYNAMIC_ROUTER_MAX_RETRIES)) | ||
| if self.retries < settings.DYNAMIC_ROUTER_MAX_RETRIES: |
There was a problem hiding this comment.
ReconnectingClientFactory does that
|
👍 |
|
Will push early next week because it needs to be monitored closely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that you want your consistent hashing ring to
adapt itself when destinations are down. This change will
remove destinations from the router when down and add them
back when up.
An additional buffer is created to store points when no
destination is up, the receiving socket is also paused in this
case to apply some back-pressure.
When a node is removed from the router its points are re-injected
to carbon to go through the new route.