Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Samples with Criteo SDK 3.8.0 #6

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Update Samples with Criteo SDK 3.8.0 #6

merged 1 commit into from
Jul 21, 2020

Conversation

irwansetiawan
Copy link
Contributor

  • Update module dependencies to Criteo SDK version 3.8.0
  • Remove Criteo private maven repository as Criteo SDK is now hosted on jCenter

@irwansetiawan irwansetiawan requested a review from a team as a code owner July 21, 2020 06:51
@irwansetiawan
Copy link
Contributor Author

Closing this PR because the branch was created on top of another branch and apparently the other branch's commits are also included in this PR.

@TurpIF TurpIF reopened this Jul 21, 2020
@TurpIF
Copy link
Contributor

TurpIF commented Jul 21, 2020 •
edited
Loading

FYI you can base a PR on another:
image

At the top of the PR, you click on edit (near the save button), then you can update the base branch from master to whatever you want.
When the other PR is merged on master, then this one will automatically be based on master again (rebase may be mandatory if there is concurrent changes).

@TurpIF TurpIF changed the base branch from master to 3.7.0-update July 21, 2020 07:13
TurpIF
TurpIF previously approved these changes Jul 21, 2020
View reviewed changes
Base automatically changed from 3.7.0-update to master July 21, 2020 07:16
@irwansetiawan irwansetiawan dismissed TurpIF’s stale review July 21, 2020 07:16

The base branch was changed.

@irwansetiawan irwansetiawan merged commit 26d23fb into master Jul 21, 2020
@irwansetiawan irwansetiawan deleted the 3.8.0-update branch July 21, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurpIF TurpIF TurpIF approved these changes

@Amokrane Amokrane Awaiting requested review from Amokrane

@vguerci vguerci Awaiting requested review from vguerci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irwansetiawan @TurpIF