Introduce 2 new decorators #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces 2 new decorators that could be used to build features such as "go back in time" using a timepicker in the top navbar. This implementation is nearly generic even though those decorator may not have other obvious utilities. Patch also: - introduces a common footer to all pages - reorganize imports of common lib such as jquery (in the header) - adds a few libraries (momentjs & co) to be able to add a timepicker. This is a delibarate choice to avoid adding too many hooks to the codebase. - introduces a "clean" method on ConsulUIManagers that may need to be clean after themselves if necessary. - rename variable use for ConsulUIManagers to be consistent on all pages. This can be used by a decorator to interact with those elements New decorators: * `navBarDecorator` allows a user to customize his navbar easily. It allows easy introduction of new components or buttons. * `fetchedResponseDecorator` allows a user to add code after data fetch. An example of usage would be to look at some custom headers and/or act on returned data to massage it. Change-Id: I3e9a9a5c127be0d03f8e1ac6b68e66d36a8ae7c0
kamaradclimber
force-pushed
the
new_decorators
branch
from
754f192
to
063c769
Compare
pierresouchay
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces 2 new decorators that could be used to build
features such as "go back in time" using a timepicker in the top navbar.
This implementation is nearly generic even though those decorator may
not have other obvious utilities.
Patch also:
This is a delibarate choice to avoid adding too many hooks to the
codebase.
clean after themselves if necessary.
pages. This can be used by a decorator to interact with those elements
New decorators:
navBarDecoratorallows a user to customize his navbar easily. Itallows easy introduction of new components or buttons.
fetchedResponseDecoratorallows a user to add code after data fetch.An example of usage would be to look at some custom headers and/or
act on returned data to massage it.