Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot's of sockets in CLOSE-WAIT #17

Closed
ashangit opened this issue Nov 13, 2018 · 4 comments
Closed

Lot's of sockets in CLOSE-WAIT #17

ashangit opened this issue Nov 13, 2018 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ashangit
Copy link
Contributor

On few of our servers during roll restart of forwarder service due to release bump we can observe bad sockets behaviour with lots of CLOSE-WAIT sockets from container to forwarder

> ss -np|grep 33000|grep CLOSE-WAIT|wc -l
26358

Netid  State      Recv-Q Send-Q Local Address:Port           Peer Address:Port      
tcp    CLOSE-WAIT 0      0      127.0.0.1:33068              127.0.0.1:33000               users:(("java",pid=46695,fd=4494))
tcp    CLOSE-WAIT 0      0      127.0.0.1:35035              127.0.0.1:33000               users:(("java",pid=46695,fd=26321))
@ashangit ashangit self-assigned this Nov 13, 2018
@ashangit
Copy link
Contributor Author

If a failure happen when agent is sending data to the forwarder we are will closing the socket but when we do handshake between agent and forwarder if there is a version check issue we don'(t close the connection from the client side.
We'll update the code to do so

@Willymontaz
Copy link
Contributor

Willymontaz commented Nov 16, 2018

Reopened until no more processes containing such agent runs on the cluster / gateways

@Willymontaz Willymontaz reopened this Nov 16, 2018
@ashangit
Copy link
Contributor Author

The patch solved this issue
If we want to follow state of the patch on our infra we should open a request in our internal repo.
Here we should only report feature, bug... and close when code is merged

@Willymontaz
Copy link
Contributor

Yes, right

ashangit pushed a commit to ashangit/garmadon that referenced this issue Jun 5, 2019
…t instead of closing the connection (criteo#20)"

Since all agents have been bumped with criteo#17 we don't neeed anymore
this patch

This reverts commit 63f891f.
ashangit pushed a commit that referenced this issue Jun 10, 2019
…t instead of closing the connection (#20)" (#148)

Since all agents have been bumped with #17 we don't neeed anymore
this patch

This reverts commit 63f891f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants