Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard messages from Agent when protocol version is incorrect instead of closing the connection #20

Conversation

Willymontaz
Copy link
Contributor

No description provided.

@ashangit
Copy link
Contributor

Please add a TODO indicating that once the migration to new agent release is performed (meaning once all JVMs have been restarted on new agent release) we should revert that commit

@ashangit ashangit self-requested a review November 16, 2018 09:39
@Willymontaz Willymontaz merged commit 63f891f into criteo:master Nov 16, 2018
ashangit pushed a commit that referenced this pull request Nov 16, 2018
@Willymontaz Willymontaz deleted the TEMPORARY_FIX_AGENT_NOT_CLOSING_GREETINGS branch November 23, 2018 07:42
ashangit pushed a commit to ashangit/garmadon that referenced this pull request Jun 5, 2019
…t instead of closing the connection (criteo#20)"

Since all agents have been bumped with criteo#17 we don't neeed anymore
this patch

This reverts commit 63f891f.
ashangit pushed a commit that referenced this pull request Jun 10, 2019
…t instead of closing the connection (#20)" (#148)

Since all agents have been bumped with #17 we don't neeed anymore
this patch

This reverts commit 63f891f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants