Release #200
Merged
Release #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with master
…'t handle the event
.. mainly to fix changingDeviceToken being null when service is restarted after termination
hide the ceremony of start/stop in static methods and launch it from app since it's really more the apps responsibility
string() now automatically closes body
…ation_change State handling and allow orientation change
no more sdk manager downloads
also a minor update to the about section
…tor_drawables Hardware state handling and vector drawables
Housekeeping and gps waiting state
otherwise service might not be restarted after close and relaunch
After app close, singletons are still alive and won't be recreated. So LUM never registers again after relaunch.
Service fix
|
From my side everything should be good to go.
…On Aug 22, 2017 10:14 PM, "stephan lindauer" ***@***.***> wrote:
@stephanlindauer <https://github.com/stephanlindauer> requested your
review on: criticalmaps/criticalmaps-android#200
<#200> Release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#200 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI1mm-2f8pe8WLVL7pKfCdY9HuwQ7-R5ks5sazaKgaJpZM4O_ILD>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'd like to release this after the cm on friday.