Misc #193
Merged
Misc #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanlindauer
approved these changes
Jun 18, 2017
…'t handle the event
.. mainly to fix changingDeviceToken being null when service is restarted after termination
hide the ceremony of start/stop in static methods and launch it from app since it's really more the apps responsibility
string() now automatically closes body
|
Can we merge this? I have some other stuff I'd like to push but don't want to bloat this PR. |
stephanlindauer
approved these changes
Jul 23, 2017
|
@cbalster Looks good so far (code review without running it). You might want to adjust some of your commit messages. They line break in the middle of the statement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.