Night mode #69

mltbnz · 2019-04-10T09:02:21Z

Night Mode

adds Light and DarkTheme
stores selected Theme in UserDefaults
adds switch in settings to set theme

Checklist

Before creating the PR

Update CHANGELOG

mltbnz · 2019-04-10T13:18:27Z

Did someone already create a custom map-style for a dark mode?

lennet · 2019-04-10T16:33:26Z

Did someone already create a custom map-style for a dark mode?

I think we have to wait until the sdk provides a public api for dark mode or a way to style maps locally.

The problem ist that custom styles for mapViews requires a webservices that provides the svg

zutrinken · 2019-04-10T17:42:17Z

Did someone already create a custom map-style for a dark mode?

@mltbnz excellent question!

@cbalster and I did some research on custom map tiles for Android based on OSM. The option is to host an own tile server, which might be quite expensive, or use a paid service. There are Mapbox and Thunderforest. The second could be an option in the future - they look quite open source friendly. Maybe there can be some cooperation, but I haven't reached out yet. That might be a job for @stephanlindauer with a better understanding of our traffic and approximately needed data package.

mltbnz · 2019-04-11T07:45:27Z

Seems like it is possible with a MKTileOverlay that points to a tile server. Would it be an option to use a already finished dark theme tile?

mltbnz · 2019-04-11T11:17:27Z

Found one here https://wiki.openstreetmap.org/wiki/Tile_servers but it doesn't look really nice I think

normansander · 2019-04-12T15:14:40Z

Very cool @mltbnz . Can you please add it also to the CHANGELOG.md? https://github.com/criticalmaps/criticalmaps-ios/blob/master/CHANGELOG.md#added

https://keepachangelog.com/en/1.0.0/

Thanks :)

zutrinken

Regarding the dark map tiles, I think we could go with this first approach. It looks quite dark on my desktop screen, but at night on a phone and full brightness it might work quite good.

But can we have a darker highlight color here please:

Chat/Twitter have a wired looking navigationbar:

mltbnz · 2019-04-26T08:39:19Z

Great you took a look at the draft. The cell hightlightColor is one of the things on my list. Also changing the textColor of the overlay. I will also make the navigationBar non transparent. Another thing is the color of the chatBubble that is not handled and also I think I will create a seperate cell for each switch cell in settings since sometimes it seems to loose the reference to its selector I guess. Didn’t had the time to look into it properly. Other then that I am pretty happy with the result. The very dark map works kind of good.
The PR is touching a lot of code though. Makes the PR kind of unreviewable but I was not able to slice it into smaller chunks. There will be no tests though for the color changes since I would need to add UI Tests to the project.

mltbnz · 2019-04-29T13:09:59Z

CriticalMass/AppController.swift

+            .init(representation: NavigationOverlayItem.Representation(button: kniggeButton),
+                  action: .navigation(viewController: getRulesViewController)),
+            .init(representation: NavigationOverlayItem.Representation(button: settingsButton),
+                  action: .navigation(viewController: getSettingsViewController)),
        ])


Updated these to be buttons also for accessability

Why is this change needed?

Makes applying a theme easier since it is only one kind. For using the app with voice over it also makes sense. Plus shortens code

It doesn't make a difference for VoiceOver and Theming because both solution are using UIButtons in the end. I don't like that we know have UIButton instances in the AppController

I updated to PR to roll back to the previous solution

mltbnz · 2019-04-29T14:29:41Z

There is still an issue with the night mode switch that sometimes is not switching the theme... Working on that. But the rest can be reviewed

mltbnz · 2019-04-30T06:19:59Z

settings switch cell issue should be fixed

zutrinken

Here my findings:

Text should be white

You can't scroll to the end in settings. The app info always scrolls back out of viewport

turning night mode off didn't work so well here

segmented control should be part of the header, means darker background color

mltbnz · 2019-04-30T15:00:19Z

So for top 1: Seems out of my reach since it is a 3rd party. Could not manipulate it so far.
top 2: Did you check out the latest code? Think I fixed it this morning :)
top 3 and 4 are fixed. Thanks

lennet

Great work! The general implementation looks good to me, however there is still some work to do before we can merge it

CriticalMass/ThemeStore.swift

CriticalMass/Colors.swift

CriticalMass/ThemeDefining.swift

CriticalMass/ThemeStore.swift

CriticalMass/SettingsViewController.swift

CriticalMass/MapViewController.swift

CriticalMass/NibProviding.swift

CriticalMass/TextFieldWithInsets.swift

CriticalMass/UIWindow+Appearance.swift

zutrinken

The tabbar is missing its translucency and shadow.

Master	Night mode

Segmented control in day mode has wrong navbar colour. text color is off as well.

Master	Night mode

CriticalMass/SettingsSection.swift

CriticalMass/en.lproj/Localizable.strings

CriticalMass/SettingsViewController.swift

* add thirdTitleTextColor * add usernameLabel to tweetCell

* add gray600 * standardize color property structure

zutrinken · 2019-05-07T12:40:33Z

one last thing: The notification bubble number has to be white - in dark and light mode

* added unit tests

mltbnz · 2019-05-07T15:11:12Z

That must have slipped back somewhere. I fixed it and added two unit tests for safety 👍

lennet

🚢

mltbnz · 2019-05-08T10:10:14Z

💪

mltbnz added the wip work in progress label Apr 10, 2019

zutrinken requested review from zutrinken, lennet and normansander April 10, 2019 21:43

mltbnz added new feature and removed wip work in progress labels Apr 23, 2019

zutrinken reviewed Apr 25, 2019

View reviewed changes

mltbnz marked this pull request as ready for review April 29, 2019 12:55

mltbnz changed the title ~~Dark mode~~ Night mode Apr 29, 2019

mltbnz commented Apr 29, 2019

View reviewed changes

zutrinken requested changes Apr 30, 2019

View reviewed changes

mltbnz requested a review from zutrinken May 1, 2019 05:47

lennet requested changes May 1, 2019

View reviewed changes

zutrinken requested changes May 2, 2019

View reviewed changes

lennet reviewed May 2, 2019

View reviewed changes

CriticalMass/SettingsSection.swift Outdated Show resolved Hide resolved

mltbnz requested review from zutrinken and lennet May 3, 2019 07:20

lennet reviewed May 3, 2019

View reviewed changes

CriticalMass/en.lproj/Localizable.strings Outdated Show resolved Hide resolved

lennet reviewed May 3, 2019

View reviewed changes

CriticalMass/en.lproj/Localizable.strings Show resolved Hide resolved

lennet reviewed May 3, 2019

View reviewed changes

CriticalMass/SettingsViewController.swift Show resolved Hide resolved

Malte Bünz added 15 commits May 6, 2019 13:15

* update tweetTableViewCell appearancne

b3e761d

* add thirdTitleTextColor * add usernameLabel to tweetCell

remove maskToBounds to give OverlayView its shadow back

4d82488

fix failing tests 🏃‍♂️

64affab

update to collect gps and nightMode switch in preferences

055394c

* remove unused colors

7adc46e

* add gray600 * standardize color property structure

apply theme in the appController

7e008eb

fix statusBarStyle in MapViewController

2b661c1

add comments

4ebee0e

add italian translation

b91cff2

remove unused strings

fc5520a

add statusBarStyle

495d2a0

update NSNotification to Notification

1b35d15

rework NavigaionOverlayController

af4c1ea

add dynamic property

fbc50cb

set custom button appearance

33585a3

mltbnz requested a review from lennet May 7, 2019 07:10

Malte Bünz added 4 commits May 7, 2019 09:21

Merge master into darkMode

4b8333a

fix CustomButton appearance

6ed538e

fix mapViewController initial tile load

cd7745a

fix tests ✅

4818835

* ChatNavigationButton appearance textColor is alwazs white now

6769c31

* added unit tests

lennet approved these changes May 7, 2019

View reviewed changes

mltbnz merged commit 9c13187 into criticalmaps:master May 8, 2019

mltbnz mentioned this pull request May 8, 2019

Notification Static #92

Merged

lennet mentioned this pull request May 11, 2019

SettingsFooterView uses deprecated API #76

Closed

mltbnz mentioned this pull request May 13, 2019

Update Components to use IBConstructable protocol #95

Merged

mltbnz deleted the darkMode branch March 3, 2020 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Night mode #69

Night mode #69

mltbnz commented Apr 10, 2019 •

edited

mltbnz commented Apr 10, 2019

lennet commented Apr 10, 2019

zutrinken commented Apr 10, 2019 •

edited

mltbnz commented Apr 11, 2019

mltbnz commented Apr 11, 2019 •

edited

normansander commented Apr 12, 2019

zutrinken left a comment •

edited

mltbnz commented Apr 26, 2019 •

edited

mltbnz Apr 29, 2019

lennet Apr 30, 2019

mltbnz May 1, 2019

lennet May 3, 2019

mltbnz May 7, 2019

mltbnz commented Apr 29, 2019

mltbnz commented Apr 30, 2019

zutrinken left a comment •

edited

mltbnz commented Apr 30, 2019

lennet left a comment

zutrinken left a comment •

edited

zutrinken commented May 7, 2019

mltbnz commented May 7, 2019

lennet left a comment

mltbnz commented May 8, 2019

Night mode #69

Night mode #69

Conversation

mltbnz commented Apr 10, 2019 • edited

Night Mode

Checklist

Before creating the PR

mltbnz commented Apr 10, 2019

lennet commented Apr 10, 2019

zutrinken commented Apr 10, 2019 • edited

mltbnz commented Apr 11, 2019

mltbnz commented Apr 11, 2019 • edited

normansander commented Apr 12, 2019

zutrinken left a comment • edited

Choose a reason for hiding this comment

mltbnz commented Apr 26, 2019 • edited

mltbnz Apr 29, 2019

Choose a reason for hiding this comment

lennet Apr 30, 2019

Choose a reason for hiding this comment

mltbnz May 1, 2019

Choose a reason for hiding this comment

lennet May 3, 2019

Choose a reason for hiding this comment

mltbnz May 7, 2019

Choose a reason for hiding this comment

mltbnz commented Apr 29, 2019

mltbnz commented Apr 30, 2019

zutrinken left a comment • edited

Choose a reason for hiding this comment

mltbnz commented Apr 30, 2019

lennet left a comment

Choose a reason for hiding this comment

zutrinken left a comment • edited

Choose a reason for hiding this comment

zutrinken commented May 7, 2019

mltbnz commented May 7, 2019

lennet left a comment

Choose a reason for hiding this comment

mltbnz commented May 8, 2019

mltbnz commented Apr 10, 2019 •

edited

zutrinken commented Apr 10, 2019 •

edited

mltbnz commented Apr 11, 2019 •

edited

zutrinken left a comment •

edited

mltbnz commented Apr 26, 2019 •

edited

zutrinken left a comment •

edited

zutrinken left a comment •

edited