Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty chat input fix #82

Merged
merged 5 commits into from
Apr 22, 2019
Merged

Empty chat input fix #82

merged 5 commits into from
Apr 22, 2019

Conversation

mltbnz
Copy link
Member

@mltbnz mltbnz commented Apr 20, 2019 •
edited
Loading

disables send button when the chat message textField isEmpty.

fixes #73

lennet
lennet approved these changes Apr 20, 2019
View reviewed changes
Copy link
Member

@lennet lennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you please add the fix to the changelog?

@zutrinken zutrinken self-requested a review April 21, 2019 05:10
zutrinken
zutrinken approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@zutrinken zutrinken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍

@mltbnz
Copy link
Member Author

mltbnz commented Apr 21, 2019

Merge the CHANGELOG was the biggest Challenge here. Every Editor adds the blank lines under ### lines of markdown files. I wanted to avoid them but now even github sneaked them in

@mltbnz
Copy link
Member Author

mltbnz commented Apr 21, 2019

@mltbnz mltbnz merged commit a1eeab9 into criticalmaps:master Apr 22, 2019
@mltbnz mltbnz deleted the emptyChatInputFix branch April 22, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zutrinken zutrinken zutrinken approved these changes

@normansander normansander normansander approved these changes

@lennet lennet lennet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid empty messages
4 participants
@mltbnz @zutrinken @normansander @lennet