Porting PyClean to python3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mix of LF and CRLF. Switch to LF as the only new line character for both one-line header fields, continuation lines in header fields and the article body.
The art dictionary contains all the usual header fields (more than 70, populated by innd). When empty, they have a None value. In some places in the code, the detection was wrong (looking at the presence of the header field name in the dictionary instead of the presence of a value).
Python 3.x no longer copies the dictionary when getting the keys, and therefore the loop fails with an exception because the dictionary is changed inside the loop. Adds an explicit copy.
Properly handle memoryview objects, encoding and decoding them when appropriate. Use UTF-8 when translating from or to strings. Also, use UTF-8 when logging articles.
This was referenced Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to apply after #7.
It is made of 3 commits: