Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying only a tag or subtarget for images in config #1491

Merged
merged 3 commits into from
May 14, 2024
Merged

Allow specifying only a tag or subtarget for images in config #1491

merged 3 commits into from
May 14, 2024

Conversation

thirteenowls
Copy link
Contributor

@thirteenowls thirteenowls commented May 12, 2024 •
edited
Loading

Closes #1169.

Also supports specifying only a hash (@sha256:...) or subtarget (-centos).

@thirteenowls thirteenowls requested a review from a team as a code owner May 12, 2024 06:50
Emilgardis
Emilgardis requested changes May 12, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small notes! Good thinking about deduping get_image/get_image_name, it's been a concern of mine!

src/docker/image.rs Outdated Show resolved Hide resolved
src/docker/mod.rs Show resolved Hide resolved
src/docker/shared.rs Show resolved Hide resolved
@Emilgardis
Copy link
Member

one thing I just thought about, would it be possible to also support a syntax like -centos, which would pick {default_image}:{default_tag}-centos?

@thirteenowls
Copy link
Contributor Author

I've pushed the requested change, as well as subtarget support. :)
Please let me know what you think, I'm not entirely confident about some bits.

@thirteenowls thirteenowls changed the title Allow specifying only a tag for images in config Allow specifying only a tag or subtarget for images in config May 12, 2024
Emilgardis
Emilgardis requested changes May 12, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change needed I think, otherwise this looks great

src/docker/image.rs Show resolved Hide resolved
@Emilgardis
Copy link
Member

Can we merge this?

@thirteenowls
Copy link
Contributor Author

I believe so! Thank you for taking the time to review my PRs. :)

@Emilgardis Emilgardis added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@Emilgardis Emilgardis added this pull request to the merge queue May 14, 2024
Merged via the queue into cross-rs:main with commit 78357ea May 14, 2024
21 checks passed
@thirteenowls thirteenowls deleted the image-tag-only branch May 14, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify only a tag for image to use
2 participants
@thirteenowls @Emilgardis