Draft & dummy implementation of account removal

[fedys]

refs gh-103

[fedys]

Please let me know your thoughts on current dummy implementation.

[coveralls]

Changes Unknown when pulling a9cf89b on fedys:issue-103 into * on cross-solution:develop*.

[TiSiE]

I like the concept to push the responsibilities of listing and removing dependent items to the modules.
But maybe an event driven approach would be more flexible and less complex...
Modules could separate the logic of listing and removing items in different listener if they want, and the Auth module does not need to provide an plugin manager, but uses a dedicated event manager, which is created relatively easy, as all necessaries are already implemented: (see #234 (comment) /the last three paragraphs)

And although it is tempting for its simplicity to use a static method as factory, we should use dedicated factory classes, because of SoC principle.

[coveralls]

Changes Unknown when pulling a6c8a3c on fedys:issue-103 into * on cross-solution:develop*.

[fedys]

@TiSiE
I made all refactorings you suggested and you were right. It is more simple and flexible. I will avoid using static method factories in the future (although there were also performance reason to use static methods). Let me know if you are happy with the current draft and I will continue with real implementation.

[TiSiE]

Looks good, go ahead! 😃

[fedys]

Let me know if you are happy with the current implementation of related objects listing. If yes, I will supply unit tests and then we can move to the second step, related objects removal.

[coveralls]

Changes Unknown when pulling b29839f on fedys:issue-103 into * on cross-solution:develop*.

[TiSiE]

Code is alright. @cbleek must review the UI

[coveralls]

Changes Unknown when pulling 73add93 on fedys:issue-103 into * on cross-solution:develop*.

[cbleek]

Am 24.08.2016 um 17:09 schrieb Mathias Gelhausen:

Code is alright. @cbleek https://github.com/cbleek must review the UI

UI is OK. @fedis please delete the found relations/entities.

Regards,

Carsten

[coveralls]

Changes Unknown when pulling 923774a on fedys:issue-103 into * on cross-solution:develop*.