Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.32.0 #524

Merged
merged 294 commits into from Nov 28, 2018
Merged

Release 0.32.0 #524

merged 294 commits into from Nov 28, 2018

Conversation

@TiSiE
Copy link
Member

TiSiE commented Nov 26, 2018

No description provided.

kilip added 30 commits Oct 19, 2018
…module
kilip and others added 9 commits Nov 23, 2018
…y everyone
* pr-522:
  [Organizations] making sure organizations and subdirectory writable by everyone
  [Core] moved yawik required modules to yawik/application-pack
  [Behat] fixed type into library
  [Global] added git attributes to remove test files in composer install
  [ReleaseTools] fixed release command bug ref #523
  [ReleaseTools] fixed subsplit command
@TiSiE TiSiE added this to the v0.32 milestone Nov 26, 2018
@TiSiE TiSiE self-assigned this Nov 26, 2018
@cbleek

This comment has been minimized.

Copy link
Member

cbleek commented on module/Auth/composer.json in c74be95 Nov 26, 2018

is this correct? 0.33-dev?

This comment has been minimized.

Copy link
Member Author

TiSiE replied Nov 26, 2018

Yes. With the release of 0.32.0, the develop branch is for the upcoming version

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 26, 2018

Coverage Status

Coverage decreased (-4.2%) to 41.705% when pulling 18af30e on release-0.32.0 into 6c5b6e2 on master.

@TiSiE

This comment has been minimized.

Copy link
Member Author

TiSiE commented Nov 26, 2018

Still, there are some things to do.

  • The travis builds for sub-modules currently fail, because \Yawik\Composer\RequireFilesPermissionInterface cannot be found.
    That's because yawik/composer-plugin is not installed.

  • When yawik/composer-plugin is installed, the travis builds still fails, because the ModuleManager tries to load the module "Cv" - which is not installed in submodule builds.

@kilip

This comment has been minimized.

Copy link
Collaborator

kilip commented Nov 27, 2018

Still, there are some things to do.

  • The travis builds for sub-modules currently fail, because \Yawik\Composer\RequireFilesPermissionInterface cannot be found.
    That's because yawik/composer-plugin is not installed.
  • When yawik/composer-plugin is installed, the travis builds still fails, because the ModuleManager tries to load the module "Cv" - which is not installed in submodule builds.

@TiSiE in submodule build you can add yawik/application-pack for full yawik main-module, or yawik/core, yawik/cv to just add needed module.

I will check submodule build now:

@TiSiE

This comment has been minimized.

Copy link
Member Author

TiSiE commented Nov 27, 2018

in submodule build you can add yawik/application-pack for full yawik main-module, or yawik/core, yawik/cv to just add needed module.

The real issue here is, even if the Cv module is neither needed nor installed, the ModuleManager still tries to load it. So it must be listed in a application config file somewhere.

@kilip

This comment has been minimized.

Copy link
Collaborator

kilip commented Nov 27, 2018

@TiSiE do you know how to reproduce that issue?

@TiSiE

This comment has been minimized.

Copy link
Member Author

TiSiE commented Nov 28, 2018

@kilip don't worry, it was my fault. The particular submodule depends indeed on yawik/cv

TiSiE added 2 commits Nov 28, 2018
* pr-521:
  [Jobs] Fixes: Salary data is not persisted
  Issue #512
  Issue #512
  Issue #512
  Issue #512
@TiSiE TiSiE merged commit 18af30e into master Nov 28, 2018
4 checks passed
4 checks passed
Scrutinizer Analysis: 1157 Issues, 1001 Patches – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 41.705%
Details
@TiSiE TiSiE deleted the release-0.32.0 branch Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.