change browser entry for rawsocket.js #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use autobahn-js with rollup and rollup-plugin-node-resolve cannot resolve the path to "lib/transport/rawsocket.js". This leads to the error that "net" cannot be imported (which is correct, it is not available because it is a core node module). rollup-plugin-node-resolve uses the Node Resolution Algorithm to resolve packages (https://nodejs.org/api/modules.html#modules_all_together). This means that the path of the file should either start with './' or '/' to be found.
|
thanks for contributing, and in particular for the explanation / links of the "why"! |
|
Well, thanks for accepting 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use autobahn-js with rollup and rollup-plugin-node-resolve cannot
resolve the path to "lib/transport/rawsocket.js". This leads to the error
that "net" cannot be imported (which is correct, it is not available
because it is a core node module).
rollup-plugin-node-resolve uses the
Node Resolution Algorithmto resolvepackages (https://nodejs.org/api/modules.html#modules_all_together).
This means that the path of the file should either start with './' or
'/' to be found.