Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RawSocket transport CI tests #1493

Open
oberstet opened this issue Feb 10, 2019 · 4 comments
Open

RawSocket transport CI tests #1493

oberstet opened this issue Feb 10, 2019 · 4 comments
Labels
CI-CD Test, build and packaging infra core enhancement

Comments

@oberstet
Copy link
Contributor

oberstet commented Feb 10, 2019

As one step, our CI already runs a whole bunch of Autobahn based examples against the tested crossbar commit (the Travis builds py36-examples and pypy3-examples).

We should add a bunch of tests specifically for RawSocket against crossbar running a RawSocket WAMP transport, eg testing different message sizes (by using different WAMP call/event test payloads) up to the configured maximum (eg 16M).

To add such a test, the following 2 files need to be modified

and a new test file ./twisted/wamp/rpc/rawsocket/ created in AB repo.

@oberstet
Copy link
Contributor Author

For background, here is a PM of a user that runs into issues with largish message sizes on crossbar / rawsocket:

The backend is using a raw socket and configures the max TX and RX message size to 16MB. We checked with the Wireshark that during the handshaking, the backend send 7F F1 00 00 to the Crossbar and the Crossbar responds with 7F F1 00 00 (I attached the Wireshark dump file). According to the WAMP spec, this means 16MB. Later when backend sends data to the frontend via Crossbar (it publishes) the Crossbar prints this error and the backend disconnects: 2019-02-09T11:53:25-0400 [Router 24184] WampRawSocketProtocol: WAMP Protocol Error (invalid serialization of WAMP message (Invalid control character at: line 1 column 65533 (char 65532))) - aborting connection 2019-02-09T11:53:25-0400 [Router 24184] failing RawSocket connection - message length exceeded: message was 1651466610 bytes, but current maximum is 16777216 bytes. There is no way the message we send is 1651466610 bytes.

@oberstet
Copy link
Contributor Author

Received feedback from the OP: the problem is not in crossbar, but the client (it mixed up / merged chunks of messages). Nevertheless, having tests on our side would be good;)

@oberstet oberstet added enhancement core CI-CD Test, build and packaging infra and removed bug needs-investigation labels Feb 11, 2019
@ecorm
Copy link

ecorm commented Feb 13, 2019

There indeed was a problem in CppWAMP, but the Crossbar problem still persists after resolving it.

See #1499

@ecorm
Copy link

ecorm commented Feb 14, 2019

As I've reported in #1499, it had nothing to do with Crossbar and problem has been resolved. It would still be a good idea to test large RawSocket messages in your tests.

kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Nov 25, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Nov 25, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Nov 26, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Nov 27, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit to openembedded/meta-openembedded that referenced this issue Nov 29, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-CD Test, build and packaging infra core enhancement
Projects
None yet
Development

No branches or pull requests

2 participants