-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST bridge: remove WAMP ticket auth forwarding #1500
Conversation
This reverts commit 703507f.
That's a scary pull request. Is this really removing ticket authentication from crossbar? |
Ah, no;) What's removed is only code that forwarded HTTP to WAMP-Ticket Auth - that code is a security problem (and the design approach unfortunately "broken by design"). we are working on a replacement for the ability to authenticate the incoming HTTP to Web services defined in crossbar .. |
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
=========================================
- Coverage 37.42% 37% -0.42%
=========================================
Files 76 77 +1
Lines 11602 11711 +109
Branches 2120 2130 +10
=========================================
- Hits 4342 4334 -8
- Misses 6839 6947 +108
- Partials 421 430 +9
Continue to review full report at Codecov.
|
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Changelog: fix: autobahn installation in docker (crossbario/crossbar#1503) new: refactor SigningKey class for reusability (crossbario/crossbar#1500, crossbario/crossbar#1501) new: expand XBR node pairing helpers fix: build with nvx by default and don't publish universal wheel. (crossbario/crossbar#1493) fix: update wamp flatbuffer schema for r2r links fix: don't clobber factory (crossbario/crossbar#1480) fix: explicitly require setuptools new: expand wamp auth scram and xbr argon2/hkdf (crossbario/crossbar#1479) fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays (crossbario/crossbar#1477) fix: XBR IDL code generator - all 4 WAMP actions working now new: add automated build of xbrnetwork CLI (single-file EXE) in CI Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
No description provided.