Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easy issue: port tests from Go to Rust #201

Open
ghost opened this issue Jun 12, 2018 · 2 comments
Open

Easy issue: port tests from Go to Rust #201

ghost opened this issue Jun 12, 2018 · 2 comments
Labels
crossbeam-channel good first issue tests

Comments

@ghost
Copy link

ghost commented Jun 12, 2018

In the following file we have already ported some tests from Go to Rust:
https://github.com/crossbeam-rs/crossbeam-channel/blob/master/tests/golang.rs

The idea is to blindly port all the tests for Go channels line by line, which will give us additional confidence in the correctness of crossbeam-channel.

In the test file, you can find stubs with links to the original tests written in Go and todos that need to be filled out.

Porting is a relatively straightforward task, so if you're looking for an approachable issue to tackle, this is the one! :) Also, you don't have to port everything at once - we'll do it incrementally in small pieces. Port as much code as you feel like!
ghost referenced this issue in crossbeam-rs/crossbeam-channel Jun 28, 2018
@gsquire
More Go Tests (#64)
22fb92d 
Here are a couple more tests for the Go suite. I left a TODO and ignored the test for now since I can't figure out how to `drop` the sending half of one channel. Hopefully this is an easy fix or perhaps I didn't port it correctly.

Part of #58
ghost referenced this issue in crossbeam-rs/crossbeam-channel Jul 8, 2018
@gsquire
Go FIFO Test (#70)
abc4f17 
Add the FIFO test as part of #58
@ghost ghost transferred this issue from crossbeam-rs/crossbeam-channel Nov 5, 2018
@itarato itarato mentioned this issue May 20, 2019
Merged
bors bot added a commit that referenced this issue May 20, 2019
@bors @itarato
Merge #380
1a598cd 
380: Port test from Go lang - goroutines r=stjepang a=itarato

Porting the [goroutines](https://github.com/golang/go/blob/master/test/chan/goroutines.go) test from the Go lang repository.

Part of #201

Any help would be appreciated.

Co-authored-by: Peter Arato <it.arato@gmail.com>
bors bot added a commit that referenced this issue May 21, 2019
@bors @itarato
Merge #380
01738d1 
380: Port test from Go lang - goroutines r=stjepang a=itarato

Porting the [goroutines](https://github.com/golang/go/blob/master/test/chan/goroutines.go) test from the Go lang repository.

Part of #201

Any help would be appreciated.

Co-authored-by: Peter Arato <it.arato@gmail.com>
@fyrchik fyrchik mentioned this issue Aug 15, 2019
Open
@ghost
Copy link

ghost commented Sep 3, 2020

Hi, if this is an issue that still needs attention, I would like to help out.

@ghost
Copy link
Author

ghost commented Sep 4, 2020

@byusti That'd be great, thank you :) You can look at the following file: https://github.com/crossbeam-rs/crossbeam/blob/master/crossbeam-channel/tests/golang.rs

There's a bunch of TODOs there with links to tests written in Go that should be ported to Rust.

@ghost ghost mentioned this issue Sep 10, 2020
Merged
@SkamDart SkamDart mentioned this issue Dec 21, 2020
Merged
bors bot added a commit that referenced this issue Dec 31, 2020
@bors
Merge #615
6c3409d 
615: Port Golang chan1.go Test r=taiki-e a=SkamDart

Rust port [chan1.go](https://github.com/golang/go/blob/master/test/ken/chan1.go)

Based on an ask in #201 

Co-authored-by: Cameron Dart <cdart@anduril.com>
This was referenced May 6, 2022
Closed
Merged
bors bot added a commit that referenced this issue May 16, 2022
@bors @alygin
Merge #824
bf4c467 
824: Golang test chan r=taiki-e a=alygin

Port of the [chan.go](https://github.com/golang/go/blob/master/test/ken/chan.go) test.

Part of #201


Co-authored-by: Andrew Lygin <alygin@gmail.com>
@alygin alygin mentioned this issue May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crossbeam-channel good first issue tests
Milestone
No milestone
Development

No branches or pull requests
0 participants