Port Golang chan1.go Test #615
Conversation
crossbeam-channel/tests/golang.rs
Outdated
| panic!("fail") | ||
| } | ||
| data[r] = 2; | ||
| drop(data); |
There was a problem hiding this comment.
Someone who is more experienced with Rust than I am probably knows why, but this blocks unless I manually drop.
Any thoughts?
There was a problem hiding this comment.
There may be an odd interaction with select macro. I'll take a look.
There was a problem hiding this comment.
@taiki-e What do I need to do to get this PR merged in?
There was a problem hiding this comment.
Even if I remove drop(data) in the r function, I couldn't reproduce block. I can reproduce block by removing the drop(data) in the s function, but it will not block if I disable parallel tests (cargo test -- --test-threads=1) or run the test individually (cargo test --test golang -- chan1::main).
@SkamDart Could you remove drop(data) in the r function and leave the link to this comment on the drop(data) in the s function as a comment? (Otherwise, LGTM)
|
Build succeeded! And happy new year! 🎉 |
Rust port chan1.go
Based on an ask in #201