Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating crossfilter to v1.4.1. #53

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Updating crossfilter to v1.4.1. #53

merged 1 commit into from
Sep 18, 2017

Conversation

saboya
Copy link
Contributor

@saboya saboya commented Sep 8, 2017

No description provided.

@esjewett
Copy link
Member

Hi - I appreciate the pull request. Question for you: Is this necessary? It looks to me like just doing npm install reductio will pull the latest version of crossfilter2 by default. When you sent this it was 1.4.1, but it is now 1.4.2. My understanding was that ^1.4.0 means "most recent version higher than 1.4.0".

Thoughts on that? Anything else that needs to change or that I'm missing? I really not an expert on NPM versioning, so it's quite possible I'm getting something wrong. Thanks!

@saboya
Copy link
Contributor Author

saboya commented Sep 18, 2017

You are correct, I am merely bumping the version. I'm not 100% sure about how npm versioning works when installing the package, but maybe because of the particular version chosen (an alpha version), my bundle ends up with multiple crossfilter versions if I install reductio alongside crossfilter 1.4.1, and that's my reasoning behind the PR.

Regards!

@esjewett
Copy link
Member

Weird - but ok, that makes some sense that it wouldn't jump from alpha versions to "real" versions. Can you change it to require ^1.4.0 and then I'll merge this? Thanks!

@saboya
Copy link
Contributor Author

saboya commented Sep 18, 2017

Done!

@esjewett esjewett merged commit cd99f50 into crossfilter:master Sep 18, 2017
@esjewett
Copy link
Member

Will target 0.6.4, but will likely wait until we need a release for another reason. Let me know if this continues to cause problems in a clean installation scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants