Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples yamls to root folder #61

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Mar 17, 2021

To make example yamls folder in the place consistent in other
Crossplane providers

Signed-off-by Zheng Xi Zhou zzxwill@gmail.com

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@zzxwill zzxwill mentioned this pull request Mar 17, 2021
2 tasks
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @zzxwill can you add commit sign off? :)

To make example yamls folder in the place consistent in other
Crossplane providers

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
@zzxwill
Copy link
Collaborator Author

zzxwill commented Mar 17, 2021

LGTM, @zzxwill can you add commit sign off? :)

Done, thanks.

zzxwill added a commit to zzxwill/provider-alibaba that referenced this pull request Mar 17, 2021
Moved copyright Year bump to crossplane-contrib#62 and examples folder changing to crossplane-contrib#61

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
@hasheddan hasheddan merged commit ff7dccf into crossplane-contrib:master Mar 17, 2021
@zzxwill zzxwill deleted the samples branch March 17, 2021 15:40
zzxwill added a commit to zzxwill/provider-alibaba that referenced this pull request Mar 17, 2021
Moved copyright Year bump to crossplane-contrib#62 and examples folder changing to crossplane-contrib#61

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
@zzxwill zzxwill mentioned this pull request Jul 20, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants