Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NAS filesystem #79

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Support NAS filesystem #79

merged 4 commits into from
Jun 24, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Jun 24, 2021

Signed-off-by: Zheng Xi Zhou zzxwill@gmail.com

Description of your changes

Support NAS filesystem

Fixes #67

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
When vpcID and vSwitchID are set,
descriptionResponse.Body.FileSystems.FileSystem becomes 0,
so we need to set fileSystemID first, not from descriptionResponse

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, thanks

@wonderflow wonderflow merged commit dbe0bc1 into crossplane-contrib:master Jun 24, 2021
@zzxwill zzxwill deleted the nas branch June 24, 2021 08:30
@zzxwill zzxwill mentioned this pull request Jul 20, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Which cloud resource would you expect to be supported by provider alibaba?
2 participants