Kubernetes Secret Kubeconfig integration

[stevendborrelli]

Description of your changes

Ready for review.

• Add ability to use a kubeconfig secret generated by Crossplane.
• Converts ClusterParameters Name, Server, and Config.TLSClientConfig to pointers as they are optional.

Fixes #13

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

• I ran this for several hours against a cluster with some debugging enabled to monitor the secret versions and ensure every time the referenced secret was updated our controller requested an update.
• Deployed an application against the cluster.

[janwillies]

Thanks for taking this on @stevendborrelli! This is our most wanted feature request. Is there anything you want to discuss before doing further work here?

[stevendborrelli]

I am still doing some testing and refactoring.

There are a couple of things I'd like some clarity on:

1. provider-argocd/pkg/controller/cluster/controller.go

   Line 118 in 14aa0b4

   if meta.WasDeleted(cr) && meta.GetExternalName(cr) == observedCluster.Name {

is causing cluster deletes to be skipped:

	if meta.WasDeleted(cr) && meta.GetExternalName(cr) == observedCluster.Name {
		// ArgoCD Cluster resource ignores the name field. This detects the deletion of the default cluster resource.
		return managed.ExternalObservation{}, nil
	}

[stevendborrelli]

@janwillies this PR is ready for review. My main concern is with the deletion code. Without the change my clusters would not delete.

[stevendborrelli]

To test this PR, you can use the EKS example for the AWS official providers at : https://github.com/upbound/provider-aws/blob/main/examples/eks/cluster.yaml.

The secret will be written to cluster-conn in upbound-system.

The example in examples/cluster/cluster-kubeconfig.yaml will use this secret to register the cluster to ArgoCD.

[MisterMX]

Thanks for your PR @stevendborrelli! Can you take a look at the remarks and also solve the conflicts?

We would be happy to see this feature in v0.3.0. Do you think you can make it in the next couple of days?

[stevendborrelli]

@MisterMX I made an initial pass changing fields to optional but there are some issues in the Mock function causing tests to fail. I'll try to get something by Friday.

[deggja]

@stevendborrelli @MisterMX
Is there any plans to still implement this? I can see that the work stopped a couple of months ago. If not, what is missing to get this implemented?

Sorry for barging in here like this.

[stevendborrelli]

Sorry for the delay everyone, I needed to add the ability to track changes to the kubeconfig, as cloud providers rotate the credentials. I've pushed a new commit that includes this tracking.

[stevendborrelli]

The PR has been updated and is ready for review.

[MisterMX]

Thank you very much for your contribition @stevendborrelli. I added two remarks to your code. Can you take a look at them?

Also, can you squash your changes into a single commit and sign it?

[stevendborrelli]

@MisterMX I've squashed the changes for the PR, and addressed your feedback.

[MisterMX]

LGTM. Thank you very much for your contribution @stevendborrelli!