Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Launch Templates #338

Closed
enderv opened this issue Sep 14, 2020 · 7 comments · Fixed by #1041
Closed

Support for Launch Templates #338

enderv opened this issue Sep 14, 2020 · 7 comments · Fixed by #1041
Labels
enhancement New feature or request

Comments

@enderv
Copy link
Contributor

enderv commented Sep 14, 2020

What problem are you facing?

Currently no support for launch template. If added these can be used for either autoscaling groups or EKS node groups.

How could Crossplane help solve your problem?

Implement a managed resource for launch templates

@enderv enderv added the enhancement New feature or request label Sep 14, 2020
@duncaan
Copy link

duncaan commented Jan 11, 2021

Would like to see this too, for use with EKS node groups, specifically.

@muvaf
Copy link
Member

muvaf commented Jan 11, 2021

@duncaan Would you be interested in completing the custom parts outlined here if we're able to generate this resource?

@annabarnes1138
Copy link

annabarnes1138 commented Jun 4, 2021

I would also like to see this. Currently I need to tag the ec2 instances that get created as part of my node groups, but the only way to do that is to use a launch template

https://github.com/aws/aws-sdk-go-v2/blob/main/service/eks/api_op_CreateNodegroup.go#L134

@annabarnes1138
Copy link

annabarnes1138 commented Jun 4, 2021

It looks like this isn't even going to be possible until PR #602 gets merged

@haarchri
Copy link
Member

haarchri commented Oct 30, 2021

aws shipped https://aws.amazon.com/de/about-aws/whats-new/2021/10/amazon-eks-nodes-groups-bottlerocket/ for user-data optionally support fields (https://github.com/bottlerocket-os/bottlerocket#kubernetes-settings) for bottlerocket we need launch-templates

@tanujd11
Copy link

Is this by any chance picked by someone for next release? Will be happy to collaborate if not.

@haarchri
Copy link
Member

@tanujd11 i can review if you open the PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
6 participants