Launch Template and Launch Template Version resources added #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanuj Dwivedi <tanuj.dwivedi@D11-tanuj.dwivedi>
tanujd11
changed the title
… set correct examples Signed-off-by: haarchri <chhaar30@googlemail.com>
haarchri
approved these changes
Dec 31, 2021
There was a problem hiding this comment.
@tanujd11 good first contribution to provider-aws - LGTM
tested Create & Delete for LaunchTemplate and LaunchTemplateVersion
- added Referencers for EKS-NodeGroup - also tested EKS-NodeGroup wird LaunchTemplate
- removed DryRun & ClientToken via Code-Generator from LaunchTemplate & LaunchTemplateVersion
- adjust code for GenerateDeleteLaunchTemplateVersionInput for removed DryRun & external-name
launchtemplate.ec2.aws.crossplane.io/test-crossplane-obj True True test-crossplane-obj
launchtemplateversion.ec2.aws.crossplane.io/test-crossplane-v3 True True 2
|
we are unable to create referencers for LaunchTemplate / LaunchTemplateVersion for EC2-Instance because of Go ImportCycle Issues - i will open an Issue in general for this
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tanuj Dwivedi tanuj.dwivedi@D11-tanuj.dwivedi
Description of your changes
The Following PR adds LaunchTemplate and LaunchTemplate Version resource to the AWS crossplane provider
Fixes #338
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
The code has been tested with manual Creation and Deletion of the example resources.