Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privatednsnamespace READY=FALSE #738

Closed
RafalMaleska opened this issue Jun 22, 2021 · 6 comments · Fixed by #740
Closed

privatednsnamespace READY=FALSE #738

RafalMaleska opened this issue Jun 22, 2021 · 6 comments · Fixed by #740
Labels
bug Something isn't working

Comments

@RafalMaleska
Copy link

RafalMaleska commented Jun 22, 2021

What happened?

When creating a new privateDNSNamespace it becomes never ready (READY=FALSE)

How can we reproduce it?

Create a privateDNSNamespace:

apiVersion: servicediscovery.aws.crossplane.io/v1alpha1
kind: PrivateDNSNamespace
metadata:
  name: testnamespace.svc.cluster.local
spec:
  forProvider:
    region: eu-central-1 
    name: testnamespace.svc.cluster.local
    vpc: vpc-123a125c
  providerConfigRef:
    name: dev-1234567890

It never becomes ready:

Status:
  At Provider:
    Operation ID:  k43dmiizk4aavpwxahj524zy2nmibeib-kq2xlla5
  Conditions:
    Last Transition Time:  2021-06-21T18:07:34Z
    Reason:                Creating
    Status:                False
    Type:                  Ready
    Last Transition Time:  2021-06-21T18:07:34Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
Events:                    <none>

What environment did it happen in?

Crossplane version:

Crossplane version: v1.1.0
Provider AWS: v0.19.0

@RafalMaleska RafalMaleska added the bug Something isn't working label Jun 22, 2021
@haarchri
Copy link
Member

hi @RafalMaleska ;)
can you check against aws-api your status ?

because in general privatednsnamespace is working on my side:

apiVersion: servicediscovery.aws.crossplane.io/v1alpha1
kind: PrivateDNSNamespace
metadata:
  name: example-privatednsnamespace
spec:
  providerConfigRef:
    name: default
  forProvider:
    region: eu-central-1
    description: "test"
    name: crossplane-private-dns-namespace-test
    vpc: vpc-aab73bc0
    tags:
      - key: cluster
        value: "my-cluster"
Status:
  At Provider:
    Operation ID:  6acudes4m6hepmczrig5bexhvppzqkfw-kq87n4af
  Conditions:
    Last Transition Time:  2021-06-22T15:37:30Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2021-06-22T15:36:27Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced

aws servicediscovery get-operation --operation-id 6acudes4m6hepmczrig5bexhvppzqkfw-kq87n4af

{
    "Operation": {
        "Id": "6acudes4m6hepmczrig5bexhvppzqkfw-kq87n4af",
        "Type": "CREATE_NAMESPACE",
        "Status": "SUCCESS",
        "CreateDate": "2021-06-22T17:36:28.023000+02:00",
        "UpdateDate": "2021-06-22T17:37:08.175000+02:00",
        "Targets": {
            "NAMESPACE": "ns-ngfbsrd3zfnp3qnj"
        }
    }
}

@blut
Copy link
Contributor

blut commented Jun 23, 2021

Hi Chris, for me, the operations Status was also SUCCESS, however, the Condition Type Ready remained on False

@RafalMaleska
Copy link
Author

@haarchri the privateDNSnamespace is created and managed by crossplane but for some reason the status is READY=FALSE.

This may have further impact when using it in a composition.

@haarchri
Copy link
Member

okay in our environment we see

 Reason:                Available
    Status:                True
    Type:                  Ready

with same Crossplane and Provider Version - IAM for Provider is enabled to Check Operations ?

@blut
Copy link
Contributor

blut commented Jun 23, 2021

I've been able to achieve the same (Reason Available, Ready True) when importing existing namespaces ( w\ external-name).
We only experience this issue creating new namespaces. Could you try this @haarchri ?

haarchri added a commit to haarchri/provider-aws that referenced this issue Jun 23, 2021
…ription is empty lateInited = true

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
haarchri added a commit to haarchri/provider-aws that referenced this issue Jun 23, 2021
…ription is empty lateInited = true

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
@haarchri
Copy link
Member

@blut added PR #740 in my testing it was a problem if the k8s resource is without description ...

haarchri added a commit to haarchri/provider-aws that referenced this issue Jul 27, 2021
…ry (common)namespace READY=FALSE

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
muvaf added a commit that referenced this issue Jul 29, 2021
Fixes #738: servicediscovery (common)namespace READY=FALSE
negz pushed a commit to negz/provider-aws that referenced this issue Nov 11, 2021
…ry (common)namespace READY=FALSE

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
…ync-group

feat(datasync): add datasync with s3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants