Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #738: servicediscovery (common)namespace READY=FALSE #740

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

haarchri
Copy link
Member

Description of your changes

Fixes #738
if description is empty the status is READY=FALSE because of lateInited = true,
also removed description in examples because it's not required

before the fix:

NAME                                                                                      READY   SYNCED   EXTERNAL-NAME
privatednsnamespace.servicediscovery.aws.crossplane.io/example-privatednsnamespace        True    True     ns-ngfbsrd3zfnp3qnj
privatednsnamespace.servicediscovery.aws.crossplane.io/testnamespace.svc.cluster.local    False   True     ns-oslzgdargwixvklp
privatednsnamespace.servicediscovery.aws.crossplane.io/testnamespace2-svc-cluster-local   False   True     ns-vbcc5n6l5wel5vfr

after the fix:

NAME                                                                                      READY   SYNCED   EXTERNAL-NAME
privatednsnamespace.servicediscovery.aws.crossplane.io/example-privatednsnamespace        True    True     ns-ngfbsrd3zfnp3qnj
privatednsnamespace.servicediscovery.aws.crossplane.io/testnamespace.svc.cluster.local    True    True     ns-oslzgdargwixvklp
privatednsnamespace.servicediscovery.aws.crossplane.io/testnamespace2-svc-cluster-local   True    True     ns-vbcc5n6l5wel5vfr

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make reviewable
18:29:28 [ OK ] go test unit-tests

create & delete multiple (common)namespaces :)

@haarchri haarchri changed the title fix servicediscovery (common)namespace READY=FALSE Fixes #738: servicediscovery (common)namespace READY=FALSE Jun 26, 2021
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small nitpick :)

pkg/controller/servicediscovery/commonnamespace/hooks.go Outdated Show resolved Hide resolved
…ry (common)namespace READY=FALSE

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
@haarchri
Copy link
Member Author

@muvaf can we go here ? thanks

@muvaf muvaf merged commit c8cc67e into crossplane-contrib:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

privatednsnamespace READY=FALSE
2 participants