Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore RDS instances from database snapshots #1087

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

danports
Copy link
Contributor

Description of your changes

Adds support for restoring RDS instances from database snapshots.

Partially addresses #813 (doesn't handle point in time restores).

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Unit tests
  • In-cluster tests on AWS

Signed-off-by: Dan Ports <danports@gmail.com>
pkg/clients/rds/rds.go Outdated Show resolved Hide resolved
@danports
Copy link
Contributor Author

danports commented Feb 2, 2022

@chlunde Can you review?

@chlunde
Copy link
Collaborator

chlunde commented Feb 3, 2022

@danports tested, works great!

Signed-off-by: Dan Ports <danports@gmail.com>
@danports danports requested a review from chlunde February 6, 2022 02:53
@chlunde chlunde merged commit cb08893 into crossplane-contrib:master Feb 6, 2022
@chlunde
Copy link
Collaborator

chlunde commented Feb 6, 2022

Thanks!

@danports danports deleted the rds-snapshot-restore branch February 6, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants