Handle NoSuchHostedZone errors on ResourceRecordSet delete #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
febarbosa182
pushed a commit
to febarbosa182/provider-aws
that referenced
this pull request
May 23, 2022
…e-contrib#1255) Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com> Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Haddleton bob.haddleton@nokia.com
Description of your changes
Updated the ResourceRecordSet controller to handle the case where the HostedZone has been deleted before the ResourceRecordSet, to prevent the ResourceRecordSet from being permanently stuck.
If the HostedZone does not exist then the ResourceRecordSet cannot exist and so this case can be handled as equivalent to a "NotFound".
Fixes #1251
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested in a local Kind environment. Reproduced the problem locally, then applied the changes and verified that the ResourceRecordSet gets deleted when the HostedZone has already been deleted.