feat(batch): Add service batch #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
requested changes
May 3, 2022
wotolom
changed the title
wotolom
force-pushed
the
master
branch
2 times, most recently
from
4b65f4b
to
ea1f51f
Compare
|
@haarchri would you like to review this? |
wotolom
force-pushed
the
master
branch
4 times, most recently
from
5b6711d
to
2146ab5
Compare
|
@wotolom can you fix lint issue ? |
-ComputeEnvironment -JobQueue -JobDefinition (manually, no ACK) -Job (manually, no ACK) Signed-off-by: wotolom <car_929@yahoo.de>
Seems to have been a timeout error (previous lint-check error line). Did another rebase and pushed again. This time the check went through. May be caused by the deprecated or disabled linters? Warnings also on current lint-check. |
2 tasks
haarchri
approved these changes
Oct 29, 2022
|
@MisterMX you need to review last time - you requested changes |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1257
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
The resources ComputeEnvironment, JobQueue, JobDefinition and Job were tested manually (create, update, delete) with the objects in examples/batch.