Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crawler): RoleRef should extract ARN #1494

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Sep 26, 2022

Description of your changes

Adds line to extract ARN from Role to be used for Crawler

I miss of my part, when I enhanced the Glue service here.

Role reference for the resource Crawler should use the ARN:

  1. for consistency -> same as the Glue resource Job
  2. with ARN through refs, users don't have to think about possible path, if other fields only take ARN

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually with the relating example.

Signed-off-by: wotolom <car_929@yahoo.de>
@haarchri
Copy link
Member

@wotolom can you fix lint ?

@wotolom
Copy link
Contributor Author

wotolom commented Sep 26, 2022

@haarchri no, it seems again - like for batch PR - to be a simple timeout error. Can you re-run the lint-check? That eventually worked in the other mentioned PR.

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haarchri haarchri merged commit d90a07b into crossplane-contrib:master Sep 27, 2022
@wotolom wotolom deleted the glue-polish branch August 23, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants