feat(rds): Add family selector to DBClusterParameterGroup #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
force-pushed
the
rds-parameter-group-family-selector
branch
from
878b387
to
e24fe6f
Compare
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
MisterMX
force-pushed
the
rds-parameter-group-family-selector
branch
from
e24fe6f
to
e1577ea
Compare
|
@haarchri do you have time to take a look at this? |
haarchri
approved these changes
May 8, 2022
febarbosa182
pushed a commit
to febarbosa182/provider-aws
that referenced
this pull request
May 23, 2022
…-contrib#1274) Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG) Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This makes
dbParameterGroupFamilyoptional and adds a new fielddbParameterGroupFamilySelectorthat will allow the controller to look up the former usingDescribeDBEngineVersions.Fixes #1273
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually