Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): Add family selector to DBClusterParameterGroup #1274

Merged
merged 1 commit into from
May 8, 2022
Merged

feat(rds): Add family selector to DBClusterParameterGroup #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apis/rds/generator-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,16 @@ ignore:
- ModifyDBInstanceInput.DBSecurityGroups
- ModifyDBInstanceInput.DBSubnetGroupName # this is immutable
- CreateDBParameterGroupInput.DBParameterGroupName
- CreateDBParameterGroupInput.DBParameterGroupFamily
- DeleteDBParameterGroupInput.DBParameterGroupName
- ModifyDBParameterGroupInput.DBParameterGroupName
- ModifyDBParameterGroupInput.DBParameterGroupFamily
- DescribeDBParameterGroupsInput.DBParameterGroupName
- CreateDBClusterParameterGroupInput.DBClusterParameterGroupName
- CreateDBClusterParameterGroupInput.DBParameterGroupFamily
- DeleteDBClusterParameterGroupInput.DBClusterParameterGroupName
- ModifyDBClusterParameterGroupInput.DBClusterParameterGroupName
- ModifyDBClusterParameterGroupInput.DBParameterGroupFamily
- DescribeDBClusterParameterGroupsInput.DBClusterParameterGroupName
- DescribeGlobalClustersInput.GlobalClusterIdentifier
- ModifyGlobalClusterInput.GlobalClusterIdentifier
Expand Down
125 changes: 125 additions & 0 deletions apis/rds/v1alpha1/custom_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,138 @@ type CustomDBParameterGroupParameters struct {
// A list of parameters to associate with this DB parameter group
// +optional
Parameters []Parameter `json:"parameters,omitempty"`

// The DB parameter group family name. A DB parameter group can be associated
// with one and only one DB parameter group family, and can be applied only
// to a DB instance running a database engine and engine version compatible
// with that DB parameter group family.
//
// To list all of the available parameter group families for a DB engine, use
// the following command:
//
// aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"
// --engine <engine>
//
// For example, to list all of the available parameter group families for the
// MySQL DB engine, use the following command:
//
// aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"
// --engine mysql
//
// The output contains duplicates.
//
// The following are the valid DB engine values:
//
// * aurora (for MySQL 5.6-compatible Aurora)
//
// * aurora-mysql (for MySQL 5.7-compatible Aurora)
//
// * aurora-postgresql
//
// * mariadb
//
// * mysql
//
// * oracle-ee
//
// * oracle-ee-cdb
//
// * oracle-se2
//
// * oracle-se2-cdb
//
// * postgres
//
// * sqlserver-ee
//
// * sqlserver-se
//
// * sqlserver-ex
//
// * sqlserver-web
//
// One of DBParameterGroupFamily or DBParameterGroupFamilySelector is required.
//
// +optional
DBParameterGroupFamily *string `json:"dbParameterGroupFamily,omitempty"`

// DBParameterGroupFamilySelector determines DBParameterGroupFamily from
// the engine and engine version.
//
// One of DBParameterGroupFamily or DBParameterGroupFamilySelector is required.
//
// Will not be used if DBParameterGroupFamily is already set.
// +optional
DBParameterGroupFamilySelector *DBParameterGroupFamilyNameSelector `json:"dbParameterGroupFamilySelector,omitempty"`
}

// CustomDBClusterParameterGroupParameters are custom parameters for DBClusterParameterGroup
type CustomDBClusterParameterGroupParameters struct {
// A list of parameters to associate with this DB cluster parameter group
// +optional
Parameters []Parameter `json:"parameters,omitempty"`

// The DB cluster parameter group family name. A DB cluster parameter group
// can be associated with one and only one DB cluster parameter group family,
// and can be applied only to a DB cluster running a database engine and engine
// version compatible with that DB cluster parameter group family.
//
// Aurora MySQL
//
// Example: aurora5.6, aurora-mysql5.7
//
// Aurora PostgreSQL
//
// Example: aurora-postgresql9.6
//
// To list all of the available parameter group families for a DB engine, use
// the following command:
//
// aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"
// --engine <engine>
//
// For example, to list all of the available parameter group families for the
// Aurora PostgreSQL DB engine, use the following command:
//
// aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"
// --engine aurora-postgresql
//
// The output contains duplicates.
//
// The following are the valid DB engine values:
//
// * aurora (for MySQL 5.6-compatible Aurora)
//
// * aurora-mysql (for MySQL 5.7-compatible Aurora)
//
// * aurora-postgresql
//
// One of DBParameterGroupFamily or DBParameterGroupFamilySelector is required.
//
// +optional
DBParameterGroupFamily *string `json:"dbParameterGroupFamily"`

// DBParameterGroupFamilySelector determines DBParameterGroupFamily from
// the engine and engine version.
//
// One of DBParameterGroupFamily or DBParameterGroupFamilySelector is required.
//
// Will not be used if DBParameterGroupFamily is already set.
// +optional
DBParameterGroupFamilySelector *DBParameterGroupFamilyNameSelector `json:"dbParameterGroupFamilySelector,omitempty"`
}

// DBParameterGroupFamilyNameSelector allows determining the family name from the
// database engine and engine version.
type DBParameterGroupFamilyNameSelector struct {
// Engine is the name of the database engine.
// +kubebuilder:validation:Required
Engine string `json:"engine"`

// EngineVersion is the version of the database engine.
// If it is nil, the default engine version given by AWS will be used.
// +optional
EngineVersion *string `json:"engineVersion,omitempty"`
}

// CustomDBClusterParameters are custom parameters for DBCluster
Expand Down
39 changes: 3 additions & 36 deletions apis/rds/v1alpha1/zz_db_cluster_parameter_group.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 3 additions & 50 deletions apis/rds/v1alpha1/zz_db_parameter_group.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 50 additions & 10 deletions apis/rds/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion examples/rds/db-aurora-clusterparametergroup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ metadata:
spec:
forProvider:
region: us-east-1
dbParameterGroupFamily: aurora-mysql5.7
dbParameterGroupFamilySelector:
engine: aurora-mysql
description: example
tags:
- key: created-by
Expand Down
Loading