[DO NOT MERGE] Add opensearch #1333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Broken on Observe step, see: crossplane-contrib#1228 (comment) Related issue: crossplane-contrib#1228 Signed-off-by: Domagoj Marsic <domagoj.marsic@sendoso.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR contains code for OpenSearch following the information in CODE_GENERATION.md.
I am facing a problem on on Observe step, where the Not Found response from the service has a different format than most other services, in particular it isn't structured to contain
awsErr.ErrororawsErr.Code.More detailed information about the issue is in:
#1228 (comment)
Description of your changes
Fixes #1228
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested